[coreboot] r1068 - in coreboot-v3: mainboard/kontron/986lcd-m northbridge/intel/i945 southbridge/intel/i82801gx

[svn at coreboot.org]

Author: myles
Date: 2008-12-10 19:50:54 +0100 (Wed, 10 Dec 2008)
New Revision: 1068

Modified:
   coreboot-v3/mainboard/kontron/986lcd-m/stage1.c
   coreboot-v3/northbridge/intel/i945/northbridge.c
   coreboot-v3/northbridge/intel/i945/raminit.c
   coreboot-v3/southbridge/intel/i82801gx/pci.c
Log:
This patch removes some warnings from the v3 kontron build.

Two unused variables, an incorrect pointer type, and two printf format
warnings.

Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>



Modified: coreboot-v3/mainboard/kontron/986lcd-m/stage1.c
===================================================================
--- coreboot-v3/mainboard/kontron/986lcd-m/stage1.c	2008-12-10 18:34:16 UTC (rev 1067)
+++ coreboot-v3/mainboard/kontron/986lcd-m/stage1.c	2008-12-10 18:50:54 UTC (rev 1068)
@@ -207,7 +207,9 @@
 {
 	void 	early_superio_config_w83627thg(void);
 	void 	ich7_enable_lpc(void);
-	int boot_mode = 0;
+
+#warning Reboot won't work until this is fixed.
+
 #if 1
 	/* hack */
 	pci_conf1_write_config32(PCI_BDF(0, 0x1f, 0), RCBA, DEFAULT_RCBA | 1);

Modified: coreboot-v3/northbridge/intel/i945/northbridge.c
===================================================================
--- coreboot-v3/northbridge/intel/i945/northbridge.c	2008-12-10 18:34:16 UTC (rev 1067)
+++ coreboot-v3/northbridge/intel/i945/northbridge.c	2008-12-10 18:50:54 UTC (rev 1068)
@@ -179,17 +179,17 @@
 #warning get number of 945 pci domain ops
 struct device_operations i945_pci_domain_ops = {
 	.id = {.type = DEVICE_ID_PCI,
-		{.pci = {.vendor = PCI_VENDOR_ID_INTEL,
-			      .device = 0x6789}}},
+	       {.pci = {.vendor = PCI_VENDOR_ID_INTEL,
+			.device = 0x6789}}},
 	.constructor		 = default_device_constructor,
-	.reset_bus		= pci_bus_reset,
+	.reset_bus		 = pci_bus_reset,
 	.phase3_scan		 = i945_pci_domain_scan_bus,
 	.phase4_read_resources	 = I945_pci_domain_read_resources,
 	.phase4_set_resources	 = I945_pci_domain_set_resources,
 	.phase5_enable_resources = enable_childrens_resources,
 	.phase6_init		 = NULL,
 	.ops_pci		 = &pci_dev_ops_pci,
-	.ops_pci_bus      = &pci_cf8_conf1,	/* Do we want to use the memory mapped space here? */
+	.ops_pci_bus		 = &pci_cf8_conf1,	/* Do we want to use the memory mapped space here? */
 };
 
 static void mc_read_resources(struct device * dev)
@@ -212,8 +212,8 @@
 	    IORESOURCE_MEM | IORESOURCE_FIXED | IORESOURCE_STORED |
 	    IORESOURCE_ASSIGNED;
 
-	printk(BIOS_DEBUG, "Adding PCIe enhanced config space BAR 0x%08lx-0x%08lx.\n",
-		     (u64) resource->base, (u64) (resource->base + resource->size));
+	printk(BIOS_DEBUG, "Adding PCIe enhanced config space BAR 0x%08llx-0x%08llx.\n",
+	       resource->base, resource->base + resource->size);
 }
 
 static void mc_set_resources(struct device * dev)

Modified: coreboot-v3/northbridge/intel/i945/raminit.c
===================================================================
--- coreboot-v3/northbridge/intel/i945/raminit.c	2008-12-10 18:34:16 UTC (rev 1067)
+++ coreboot-v3/northbridge/intel/i945/raminit.c	2008-12-10 18:50:54 UTC (rev 1068)
@@ -1069,8 +1069,8 @@
 		0x33, 0x00, 0x11, 0x00, 0x44, 0x44, 0x33, 0x11	
 	};
 
-	const u8 * strength_multiplier;
-	const u8* const * slew_group_lookup;
+	const u8 *strength_multiplier;
+	const u8 *slew_group_lookup;
 	int idx;
 
 	/* Set Strength Multipliers */

Modified: coreboot-v3/southbridge/intel/i82801gx/pci.c
===================================================================
--- coreboot-v3/southbridge/intel/i82801gx/pci.c	2008-12-10 18:34:16 UTC (rev 1067)
+++ coreboot-v3/southbridge/intel/i82801gx/pci.c	2008-12-10 18:50:54 UTC (rev 1068)
@@ -57,7 +57,6 @@
 static void ich_pci_dev_enable_resources(struct device *dev)
 {
 	const struct pci_operations *ops;
-	u16 command;
 
 	/* Set the subsystem vendor and device id for mainboard devices */
 	ops = ops_pci(dev);
@@ -72,6 +71,7 @@
 	}
 
 #if 0
+	u16 command;
 	/* If we write to PCI_COMMAND, on some systems 
 	 * this will cause the ROM and APICs not being visible
 	 * anymore.