[coreboot] [RFC] Error out on implicit declarations

[Myles Watson]

On Thu, Dec 18, 2008 at 3:04 PM, Corey Osgood <corey.osgood at gmail.com>wrote:

> On Thu, Dec 18, 2008 at 2:56 PM, Corey Osgood <corey.osgood at gmail.com>wrote:
>
>> On Thu, Dec 18, 2008 at 2:38 PM, Corey Osgood <corey.osgood at gmail.com>wrote:
>>
>>> On Thu, Dec 18, 2008 at 2:28 PM, Myles Watson <mylesgw at gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Dec 18, 2008 at 12:24 PM, Corey Osgood <corey.osgood at gmail.com>wrote:
>>>>
>>>>> On Thu, Dec 18, 2008 at 11:37 AM, Corey Osgood <corey.osgood at gmail.com
>>>>> > wrote:
>>>>>
>>>>>> On Thu, Dec 18, 2008 at 10:58 AM, ron minnich <rminnich at gmail.com>wrote:
>>>>>>
>>>>>>> I like this idea a lot, I have no idea why we did not have that
>>>>>>> enabled before ... I'm glad I'm on vacation and you all can fix it
>>>>>>> :-)
>>>>>>
>>>>>>
>>>>>> I'm all for it. CN700 should be all ready for the change.
>>>>>>
>>>>>
>>>>> I retract that, I was thinking of v3. Attached patch fixes v2.
>>>>>
>>>>  Index: src/northbridge/via/cn700/vgachip.h
>>>> ===================================================================
>>>> --- src/northbridge/via/cn700/vgachip.h (revision 3818)
>>>> +++ src/northbridge/via/cn700/vgachip.h (working copy)
>>>> @@ -1,6 +1,6 @@
>>>>  /*
>>>>  * This file is part of the coreboot project.
>>>> - *
>>>> + *;
>>>>
>>>> I'm curious about this extra semicolon.  Besides that:
>>>>
>>>> Acked-by: Myles Watson <mylesgw at gmail.com>
>>>
>>>
>>> Ah, I was looking for that! I have a bad habit of hitting my touchpad
>>> while typing and moving the cursor. Thanks, r3819
>>>
>>
>> I just got another implicit declaration in i82810, and i82801xx is clean.
>> Someone ought to check i440bx, i830, and the other via chipsets, vt8623 will
>> probably have the same ones cn700 did, but I've got to get back to work.
>>
>
> Here's another patch to clear up a bunch more, not all of them by far. I'm
> for the most part avoiding k8 and sticking with the simpler ones.
>

Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081218/bd8e449e/attachment.html>