[coreboot] r3818 build service

[Marc Jones]

On Thu, Dec 18, 2008 at 8:35 PM, Myles Watson <mylesgw at gmail.com> wrote:
>
>
> On Thu, Dec 18, 2008 at 8:13 PM, Myles Watson <mylesgw at gmail.com> wrote:
>>
>>
>> On Thu, Dec 18, 2008 at 5:16 PM, Marc Jones <marcj303 at gmail.com> wrote:
>>>
>>> On Thu, Dec 18, 2008 at 12:10 PM, Myles Watson <mylesgw at gmail.com> wrote:
>>> >
>>> >
>>> > On Thu, Dec 18, 2008 at 11:42 AM, coreboot information
>>> > <info at coresystems.de>
>>> > wrote:
>>> >>
>>> >> Dear coreboot readers!
>>> >>
>>> >> This is the automated build check service of coreboot.
>>> >>
>>> >> The developer "myles" checked in revision 3818 to
>>> >> the coreboot source repository and caused the following
>>> >> changes:
>>> >>
>>> >> Change Log:
>>> >> This patch gets rid of all the implicit definition warnings for
>>> >> serengeti
>>> >> except get_nodes.
>>> >>
>>> >> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>>> >> Acked-by: Marc Jones <marcj303 at gmail.com>
>>> >>
>>> >>
>>> >> Build Log:
>>> >> Compilation of asus:m2v-mx_se has been broken
>>> >> See the error log at
>>> >>
>>> >> http://qa.coreboot.org/log_buildbrd.php?revision=3818&device=m2v-mx_se&vendor=asus
>>> >
>>> > Should this board have HAVE_HARD_RESET 1?  That fixes the build.  If
>>> > not,
>>> > I'm not sure how to fix the macro definition of hard_reset in
>>> > src/include/part/hard_reset.h.  It seems strange to hang without a
>>> > message,
>>> > but that's not what's causing the build failure.
>>>
>>> Yes, I think that is the problem. It has a hard reset function in
>>> cache_as_ram_auto.c but the function is empty. Remove the function and
>>> leave the macro?
>>
>> Then the build is still broken.  The empty function says that the board
>> should have a hard_reset, but it's not implemented.  I think the right thing
>> to do is define HAVE_HARD_RESET and add a #warning that it isn't
>> implemented.  Thoughts?
>>
>> Thanks,
>> Myles
>>
>
> Index: src/mainboard/asus/m2v-mx_se/Options.lb
> ===================================================================
> --- src/mainboard/asus/m2v-mx_se/Options.lb     (revision 3820)
> +++ src/mainboard/asus/m2v-mx_se/Options.lb     (working copy)
> @@ -96,7 +96,7 @@
>  default ROM_SIZE = 512 * 1024
>  default FALLBACK_SIZE = 256 * 1024
>  default HAVE_FALLBACK_BOOT = 1
> -default HAVE_HARD_RESET = 0
> +default HAVE_HARD_RESET = 1
>  default HAVE_PIRQ_TABLE = 0
>  default IRQ_SLOT_COUNT = 11    # FIXME?
>  default HAVE_MP_TABLE = 1
> Index: src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c
> ===================================================================
> --- src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c    (revision 3820)
> +++ src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c    (working copy)
> @@ -126,6 +126,7 @@
>  {
>  }
>
> +#warning No hard_reset implemented for this board!
>  void hard_reset(void)
>  {
>         print_info("NO HARD RESET. FIX ME!\n");
>
> This patch fixes the build for asus/m2v-mx_se.  Its hard_reset function is
> not
> implemented (It just prints "hard_reset not implemented.  FIX ME!" This
> patch
> defines HAVE_HARD_RESET 1 and adds a #warning hard_reset not implemented.
>
> The net effect is that hard_reset prints something instead of just entering
> an
> infinite loop.
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
Agreed.
Acked-by: Marc Jones <marcj303 at gmail.com>