[coreboot] r1083 - coreboot-v3/mainboard/kontron/986lcd-m

svn at coreboot.org svn at coreboot.org
Tue Dec 23 07:59:04 CET 2008

Author: rminnich
Date: 2008-12-23 07:59:04 +0100 (Tue, 23 Dec 2008)
New Revision: 1083

Quick emergency fix for unitialized variable. A number of recent changes 
have resulted in breaking the kontron port. I am trying to fix them. 

In case there is any concern about the initialization: 
this is a scalar auto being initialized. 
The initialization is done in code. I have verified this both by checking
the object code and actually running it; this fix resolves a break introduced
at some point. 

Other breakage remains: kontron now hangs here: 
run_file returns with 0
Done RAM init code
Done printk() buffer move
disable_car entry
disable_car global_vars copy done
disable_car global_vars pointer adjusted
entering asm code now

Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
Acked-by: Ronald G. Minnich <rminnich at gmail.com>

Modified: coreboot-v3/mainboard/kontron/986lcd-m/initram.c
--- coreboot-v3/mainboard/kontron/986lcd-m/initram.c	2008-12-22 17:36:06 UTC (rev 1082)
+++ coreboot-v3/mainboard/kontron/986lcd-m/initram.c	2008-12-23 06:59:04 UTC (rev 1083)
@@ -157,7 +157,7 @@
 int main(void)
-	int boot_mode;
+	int boot_mode = 0;
 	void i945_early_initialization(void);
 	void enable_smbus(void);
 	int fixup_i945_errata(void);

More information about the coreboot mailing list