[coreboot] [PATCH] SeaBIOS - vgahooks improvements

Rudolf Marek r.marek at assembler.cz
Fri Dec 26 17:53:52 CET 2008


> I think I understand your patch a little bit better now. 

OK good.

> The first
> pci device is used to obtain the framebuffer size, and the second
> device is used to find the ram speed.

Yep. Check this:

(page 70)

Its from VX800 (which Jason already added in his not yet published patch)
Its exactly the same as for K8M890.

The memory speed is in: 

> Perhaps we should break this into two separate functions - that way
> it's clear that each device provides independent information.
> (Something like the attached?)

Yes, but please leave it with the warnings as I did. It is difficult to know 
where is the problem if we blindly supply default without knowing.

> Also, does unichrome/openchrome drivers need the framebuffer size?
> It seems odd to me that they'd read a scratch register for that, when
> they could just as easily read the real register.

Yes it is like that. Perhaps to make it more hw independent?


More information about the coreboot mailing list