[coreboot] patch: init gx cache earlier.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Feb 4 00:26:38 CET 2008


On 03.02.2008 21:49, ron minnich wrote:
> This change moves the geodelxinit code from stage2 to stage1, which in 
> turn gets cache turned on much sooner. The system boots a bit faster. 
>
> We're still far too slow, perhaps because we are not caching ROM?
>   

Have you tried adding a "fillup" file to the lar which occupies the
remaing unsused space? That should help a lot.

Besides that, having a boot time breakdown to find the worst offenders
is an investment into the future. But how should we implement that?
Maybe a Kconfig variable which adds TSC timestamps to all printk()
calls? While rdtsc() is slow, it is not slow enough to actually show up
in profiles if we use it together with printk.

> Index: arch/x86/Makefile
> Add geodelxinit.o object
> Index: arch/x86/geodelx/geodelxinit.c
> svn move here from geode northbridge directory and add sizeram function. 
> Index: arch/x86/geodelx/stage1.c
> add called to northbridge_init_early()
> Index: northbridge/amd/geodelx/Makefile
> remove geodelxinit.o object
> Index: northbridge/amd/geodelx/geodelxinit.c
> svn move this to arch/x86/geodelx
> Index: northbridge/amd/geodelx/geodelx.c
> remove call to northbridge_init_early()
>
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>

I'm not sure about this patch. It increases stage0/stage1 size and seems
to move northbridge init to a generic arch directory. How northbridge
specific is geodelxinit.c? Is it a piece of northbridge code? We could
link northbridge/amd/geodelx/geodelxinit.c into stage1 even if it is
inside the northbridge dir.

Regards,
Carl-Daniel





More information about the coreboot mailing list