[coreboot] patch: init gx cache earlier.
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Mon Feb 4 19:02:42 CET 2008
On 04.02.2008 18:40, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>> On 04.02.2008 16:45, ron minnich wrote:
>>
>>> we can provide a function, cycles, in the arch-dependent code. cycles
>>> returns whatever makes sense for the architecture.
>>>
>>> Then this patch can be cleaned up.
>>>
>>
>> What about this? (Varargs stuff still needs to get fixed.)
>>
> What exactly do you intend to fix?
vtxprintf expects to get called with va_list. My call to vtxprintf is
wrong, but I forgot how to do it the right way.
>> #endif /* ARCH_X86_CPU_H */
>> Index: lib/console.c
>> ===================================================================
>> --- lib/console.c (Revision 571)
>> +++ lib/console.c (Arbeitskopie)
>> @@ -34,11 +34,16 @@
>> {
>> va_list args;
>> int i;
>> + u32 tstamp;
>>
>> if (msg_level > console_loglevel()) {
>> return 0;
>> }
>>
>> + tstamp = get_timestamp();
>> +#error vtxprintf expects varargs, need to fix up
>>
>
> NACK.
The #error will not be committed, of course. It is just there because I
don't know how to call vtxprintf correctly. Please help.
>> + vtxprintf(console_tx_byte, (void *)0, "[tstamp %d] ", tstamp);
>> +
>> va_start(args, fmt);
>> i = vtxprintf(console_tx_byte, (void *)0, fmt, args);
>> va_end(args);
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the coreboot
mailing list