[coreboot] [PATCH] v3: move CAR base and CAR size to invisible Kconfig
c-d.hailfinger.devel.2006 at gmx.net
Mon Feb 11 02:39:15 CET 2008
[sorry, saw your mail too late]
On 11.02.2008 02:03, Stefan Reinauer wrote:
> * Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [080211 01:57]:
>> CAR size and CAR base defines are scattered all over the place. Set them
>> centrally from Kconfig, but keep the Kconfig variables hidden.
>> That way, they are available everywhere, you don't have to try to guess
>> where they are set, and they come with help text if you look at
>> No semantic changes, although some of the settings really could use an
>> This also is a requirement for my printk buffer patch.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> NACK. Search the archives for previous discussion on this.
The archives do not turn up any relevant hits for "CAR Kconfig" or
"cache Kconfig". More details about what to search for would be appreciated.
> The config
> system is not there to set code internal only variables. That's what the
> arch/x86 cpu dependent include files are there for.
Actually, this is one of the good aspects of v2: setting
subarch-dependant variables dependant on subarch and/or mainboard.
How do you define "code internal only variables"? I think variables with
arch-dependent value (as opposed to arch-dependent existence) should be
set by Kconfig. There is no reason to have stuff like LX_NUM_CACHELINES
in Kconfig because it doesn't even exist on other subarches.
More information about the coreboot