[coreboot] [PATCH] v3: move CAR base and CAR size to invisible Kconfig

Peter Stuge peter at stuge.se
Mon Feb 11 03:53:30 CET 2008

On Mon, Feb 11, 2008 at 02:39:15AM +0100, Carl-Daniel Hailfinger wrote:
> > The config system is not there to set code internal only
> > variables.


> > That's what the arch/x86 cpu dependent include files are there
> > for.

Which files?

> How do you define "code internal only variables"? I think variables
> with arch-dependent value (as opposed to arch-dependent existence)
> should be set by Kconfig.

..also valid point. This is why I liked it - the values always need
to be set. But Stefan is right in that we are overloading a
configuration mechanism.

Linux solves this by using Kconfig to pick what objects to build, and
two objects can provide the same functions but with different
implementation. Do we just want better code abstraction? Could a
#define be used to #include one .S from another .S ?

> There is no reason to have stuff like LX_NUM_CACHELINES in Kconfig
> because it doesn't even exist on other subarches.

Yes, agreed.


More information about the coreboot mailing list