[coreboot] [openvsa] patch: consistent application of LGPL
Marc.Jones at amd.com
Tue Feb 12 01:48:38 CET 2008
Uwe Hermann wrote:
> On Sat, Feb 09, 2008 at 01:19:58PM -0800, Chris Kilgour wrote:
>> AMD released the VSA code base under LGPL v2.1 in 2006, so
> LGPL-v2.1-or-later to be precise.
>> Also add a copy of the LGPL v2.1 to the OpenVSA tree
> Yep, good idea.
>> Index: sysmgr/sysmgr.h.S
>> --- sysmgr/sysmgr.h.S (revision 2)
>> +++ sysmgr/sysmgr.h.S (working copy)
>> @@ -1,4 +1,22 @@
>> + Copyright (c) 2006 Advanced Micro Devices,Inc. ("AMD").
>> + This library is free software; you can redistribute it and/or
>> + modify it under the terms of the GNU Lesser General Public
>> + License as published by the Free Software Foundation; either
>> + version 2.1 of the License, or (at your option) any later
>> + version.
>> + This code is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + GNU Lesser General Public License for more details.
>> + You should have received a copy of the GNU Lesser General
>> + Public License along with this library; if not, write to the
>> + Free Software Foundation, Inc., 59 Temple Place, Suite 330,
>> + Boston, MA 02111-1307 USA
>> // Build flags for various optional features
>> #define HISTORY 0 // History support (value determines size of history buffer; 0=disabled)
> Patch looks good in general, but I'm not sure about the above change.
> You're adding a license to a file which didn't have one before and where
> you are not the copyright owner. I'm pretty sure the intention of AMD
> was to release _all_ files under LGPL, but I'd still like to get an
> ACK from someone at AMD, just to be sure.
> Otherwise this is:
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Marc Jones <marc.jones at amd.com>
All the files were released under the LGPL. If there is a header missing
it is an over site by AMD and should be corrected.
I will try to get to building and trying the code tomorrow.
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot