[coreboot] r593 -

[Stefan Reinauer]

Peter Stuge wrote:
> I have issues with parts of this.
>
>
> On Wed, Feb 13, 2008 at 10:00:21PM +0100, svn at coreboot.org wrote:
>   
>> M    include/device/path.h
>> Add LPC path type, replacing SUPERIO path type, since SUPERIO is
>> only one type of LPC. Clean up tabbing in parts of the file
>> (cosmetic).
>>     
>
> I think this needs more discussion.
>
> Are all superios we want to support indeed LPC? Will that stay true?
>
> Is the code generic enough to work for any LPC device?
> (Flash chip, EC, custom hardware?)
>   
You are right. I think it should stay SuperIO.

>>  {
>>  	ramsize = "128";
>>  	constructor = "i440bx_constructors";
>> +	domainid = "0x8086, 0x7190";
>>  };
>>     
>
> Again, does this identify a new domain created by this device, or
> does it identify this device within the containing domain? Can we
> escape this ambiguity?
>   
I don't even think this should be in the dts at all. The driver code 
should know which pci ids to bind to. And we are doing this already:

>> +	 .ops = &i440bxemulation_pcidomainops},
>>  	{.id = {.type = DEVICE_ID_PCI,
>>  		.u = {.pci = {.vendor = 0x8086,.device = 0x7190}}},
>>     

> These ids are repeated four times, that is at least two times too
> many. Yes, this device id is both a PCI device and a domain, but
> still.
>
>   
Fully agreed.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080214/f8afd1aa/attachment.sig>