[coreboot] [PATCH] Move v3 config variables to Kconfig style
c-d.hailfinger.devel.2006 at gmx.net
Thu Feb 14 22:22:54 CET 2008
On 14.02.2008 21:59, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>> On 14.02.2008 19:31, Stefan Reinauer wrote:
>>> Carl-Daniel Hailfinger wrote:
>>>> v3 still has many places where config variables are tested with #if in
>>>> v2 style. That fails silently in v3. Fix up the most obvious ones.
>>>> Signed-off-by: Carl-Daniel Hailfinger
>>>> <c-d.hailfinger.devel.2006 at gmx.net>
>>> While the patch itself is discussable, it is cosmetics and not a fix.
>>> In fact you are removing the check of the CONFIG_ variable's value,
>>> and so if for some reason someone sets a defined value to 0, THEN the
>>> code would fail silently after applying your diff.
>>> Can you please elaborate how any of the lines you touch would cause
>>> silent failure in v3?
>> All of them. These values are Kconfig bools and if they are set, they
>> are set to "y" and not 1.
> That's wrong, so the answer is indeed "none of them" as I expected.
> Here's an excerpt from config.h as generated by Kconfig:
I stand corrected. However, the test for the #define being 1 is
superfluous if the #define is a bool.
New patch description:
Remove superfluous checks for boolean CONFIG_* variables where we tested
CONFIG_* == 1. If those variables are set, they will always be 1.
More information about the coreboot