[coreboot] Changes for removing IDs from dts, etc. etc.

Corey Osgood corey.osgood at gmail.com
Sat Feb 16 00:41:06 CET 2008


On Fri, Feb 15, 2008 at 1:23 PM, ron minnich <rminnich at gmail.com> wrote:

> This turned into a pretty big cleanup. However, it reduced (by a small
> amount) the amount of code, and complexity, and I like it.
>
> Comments welcome. This one is signed off, though there is a bit of
> todo left as noted in the patch.
>
> boots on qemu and alix1c.
>
> thanks
>
> ron


Well, since everyone else seems to be asleep, I'll have a peak.

--- southbridge/intel/i82371eb/i82371eb.c    (revision 600)
> +++ southbridge/intel/i82371eb/i82371eb.c    (working copy)
> @@ -83,7 +83,9 @@
>  }
>
>  /* You can override or extend each operation as needed for the device. */
> -static struct device_operations i82371eb_isa_ops_dev = {
> +struct device_operations i82371eb_isa = {
> +    .id = {.type = DEVICE_ID_PCI,
> +        .u = {.pci = {.vendor = 0x8086,.device = 0x7000}}},


sweet, but why no longer static?

Other than that, this looks good, but I'd hold off on committing a little
bit, to give someone a chance to nack.

Acked-by: Corey Osgood <corey.osgood at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080215/b04ab19c/attachment.html>


More information about the coreboot mailing list