[coreboot] [PATCH] v3: update mainboard dts files to new style

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Feb 17 12:56:22 CET 2008


On 17.02.2008 04:57, Peter Stuge wrote:
> On Sun, Feb 17, 2008 at 12:23:38AM +0100, Carl-Daniel Hailfinger wrote:
>   
>> All GeodeLX-based boards now include the geodelx/domain,
>> geodelx/apic and geodelx/pci dts files.
>>     
>
> Please add .dts to these filenames first, or do it along with the
> patch.
>
> If we do not start naming the dts files properly now, we may never.
>
> With rename:
>
> Acked-by: Peter Stuge <peter at stuge.se>
>   

We can always rename stuff later. Right now the contents of all 
mainboard dts files except one don't even have the specified syntax. 
Conformance before cosmetics, I'd say.

So yes, I'd like to commit without the rename and leave the rename to a 
later commit (if any). Besides that, making the syntax conform to the 
spec is an entirely different change from moving and should be in a 
separate changeset.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list