[coreboot] [patch] superiotool dumps environmental controller registers too
c-d.hailfinger.devel.2006 at gmx.net
Fri Feb 22 23:15:50 CET 2008
On 21.02.2008 19:05, Ronald Hoogenboom wrote:
> I've extended the ite.c part to include dumping the environmental
> controller register contents too. It's amazingly easy to add such
While I agree with you that adding that dumping capability was easy, I
consider the actual implementation an abuse of the existing dumping
functionality, but it's a clever abuse, so I'm not going to veto it.
The dumping capability part of the patch is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Only IT8716f (that's the only datasheet I have at the moment).
I checked the data sheets of the whole IT87 series and although the
environment controller is sometimes called fan controller, the location
of the register is the same for all models.
> Signed-off-by: Ronald Hoogenboom <hoogenboom30 at zonnet.nl>
There is one problem I'd like to solve before committing: The name of
the parameter. While "--ec-dump" or "--ecdump" sound great at first,
both of them have the problem that the acronym "EC" is ambiguous in the
context of Super I/O chips. It can either mean "Environment Controller"
or "Embedded Controller". In the future, superiotool will be able to
dump settings of both types of these devices, so I fear the parameter
has to be replaced by something like "--environ-dump".
Thoughts? We should wait with the commit until there is consensus about
the name of the long option.
More information about the coreboot