[coreboot] a simple zero fill patch
Myles Watson
mylesgw at gmail.com
Mon Feb 25 23:57:07 CET 2008
On Mon, Feb 25, 2008 at 3:42 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 25.02.2008 23:26, Myles Watson wrote:
> > On Mon, Feb 25, 2008 at 3:20 PM, Carl-Daniel Hailfinger
> > <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> >
> >> On 25.02.2008 23:13, Myles Watson wrote:
> >> > This patch adds a config option for zero-filling coreboot.rom after
> >> > adding a payload. It depends on having a payload so that you can't
> >> > end up with a file with no payload and no possiblility to add one.
> >> > The default is no zero-filling.
> >>
> >>
>
> > Signed-off-by: Myles Watson <mylesgw at gmail.com>
> >
>
> > Index: Kconfig
> > ===================================================================
> > --- Kconfig (revision 620)
> > +++ Kconfig (working copy)
> > @@ -148,5 +148,13 @@
> > payload in, coreboot can not parse it. We hope to remove ELF
> > entirely in the future.
> >
> > +config ZERO_AFTER_PAYLOAD
> > + bool "Zero fill lar after adding the payload"
> > + depends PAYLOAD_ELF
> > + default n
> > + help
> > + This option speeds booting but makes it so that no further files may
> > + be added to the lar.
> > +
> > endmenu
> >
> > Index: arch/x86/Makefile
> > ===================================================================
> > --- arch/x86/Makefile (revision 620)
> > +++ arch/x86/Makefile (working copy)
> > @@ -87,6 +87,9 @@
> > ../util/lar/lar $(PARSEELF) $(COMPRESSFLAG) -a \
> > ../coreboot.rom normal/payload;
> > endif
> > +ifeq ($(CONFIG_ZERO_AFTER_PAYLOAD),y)
> >
>
> Maybe add a message about zerofilling right here.
Done.
> > + $(Q)cd $(obj) && ./util/lar/lar -z ./coreboot.rom
> > +endif
> > $(Q)# QEMU wants bios.bin:
> > $(Q)# Run "qemu -L build/ -serial stdio -hda /dev/zero".
> > $(Q)printf " CP $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
> >
>
> Otherwise, I like it.
>
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Rev 621.
Thanks,
Myles
>
> Regards,
> Carl-Daniel
>
> --
> http://www.hailfinger.org/
>
>
More information about the coreboot
mailing list