[coreboot] [PATCH] v3: convert fake SPD to struct spd_entry

Uwe Hermann uwe at hermann-uwe.de
Tue Feb 26 20:04:52 CET 2008

On Tue, Feb 26, 2008 at 07:53:16PM +0100, Carl-Daniel Hailfinger wrote:
> Convert all boards using fake SPD entries to struct spd_entry, thereby 
> making sure we return 0xff for nonexisiting entries and shrinking the 
> data structure by 85%.

Can you elaborate? 85% less in RAM or in ROM? How did you measure this?

> As a bonus, the various initram.c for boards with fake SPD are now 
> almost identical.

Nice! (next step: generic code in lib/, drop per-board code)

> +struct spd_entry {
> +	u8 address;
> +	u8 data;
>  };

As this is the same in each file it should probably go in some header.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list