[coreboot] GENFADT and GENDSDT

Uwe Hermann uwe at hermann-uwe.de
Thu Feb 28 21:22:08 CET 2008

On Thu, Feb 28, 2008 at 06:18:04PM +0100, Carl-Daniel Hailfinger wrote:
> On 28.02.2008 12:52, Carl-Daniel Hailfinger wrote:
> > On 28.02.2008 08:55, Corey Osgood wrote:
> >> Signed-off-by: Corey Osgood <corey.osgood at gmail.com>
> >>   
> > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> >
> > We may want to rewrite genfadt in a way where all constant members of 
> > fadt are initialized at compile time instead of at run time. This 
> > probably even decreases the size of the binary and improves speed at 
> > run time.
> The more I look at the code, the less I believe the two tools with 
> completely different purposes should be in one file. If you look at 

Maybe not one file (but I think it's fine too), but definately one
project/directory and one binary (which can be invoked with multiple
switches). Any ACPI-related functionality should we hack up should be
in one tool IMO.

> I hereby retract my signoff until we have discussed whether the merge 
> makes sense for any reason besides disliking small utilities.

It does IMO. Also, why should we keep them separate? There's no
advantage in doing that, it only needlessly increases the number of
small tools coreboot users are confronted with. Let's make it simpler
for users rather than more confusing.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list