[coreboot] [PATCH] v3: convert fake SPD to struct spd_entry

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Feb 29 22:04:19 CET 2008

On 29.02.2008 21:47, Stefan Reinauer wrote:
> * Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [080226 19:53]:
>> Convert all boards using fake SPD entries to struct spd_entry, thereby 
>> making sure we return 0xff for nonexisiting entries and shrinking the 
>> data structure by 85%.
> 85% of 128 bytes? Therefore this is O(n) now instead of O(1) in ROM
> accesses. Are you sure?

Well, since we need the fake SPD in initram, we can't compress it and 
really lose that space in ROM. That's why I decided to accept higher 
lookup cost to achieve space savings. However, if anybody can show that 
the increased code complexity costs us more ROM space than what we save 
by converting the data structure from a direct access array to an 
iterated list, I'm all for changing it back.



More information about the coreboot mailing list