[LinuxBIOS] [PATCH] beautify m57sli mptable.c (Was: Fix FireWire...)

Torsten Duwe duwe at lst.de
Sun Jan 6 15:01:47 CET 2008

I still owe you a beautification patch.

On Thursday 20 December 2007, ron minnich wrote:
> Hi Torsten, why not add the comments and readable indentation right
> now? once it is committed, it won't happen :-)

It's not indentation. I found the extra long lines and useless comments 
extremely ugly and obfuscating.

This patch would again qualify as trivial by Russ' definition, but coding 
style matters so I want to bring this to discussion. IMO this is what 
preprocessor macros were invented for. We now have bus,dev,fn tuples 
together, and can easily see that 1:0a.0 maps to "pin" 18. Removing all that 
redundant blurb also makes room for meaningful comments 8-)

Signed-off-by: Torsten Duwe <duwe at lst.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: beautify-mptable
Type: text/x-diff
Size: 5375 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080106/7fcebb40/attachment.bin>

More information about the coreboot mailing list