[LinuxBIOS] [PATCH] v3: add a check for a termination member
ron minnich
rminnich at gmail.com
Sun Jan 6 20:29:58 CET 2008
On Jan 6, 2008 3:29 AM, Stefan Reinauer <stepan at coresystems.de> wrote:
> And we can't cache the ROM because of CAR?
yes.
>
> I am not convinced that failing to find files has to be a performance
> critical path - While I generally agree it must not take several
> seconds, something's wrong with our logic if we fail to find files
> before we have RAM and Cache enabled.
I think we should eliminate all unnnecessary overhead. Scanning (e.g.)
2 Mbytes of memory for each failed lookup -- all the other BIOSes are
going to point at us and make rude comments :-)
I really would like us to have a reasonable termination instead of
searching all of memory. It can be anything -- make a file name called
EOF. Carl-Daniel's design was nice because it was very flash-friendly,
but I'm not picky.
thanks
ron
More information about the coreboot
mailing list