[LinuxBIOS] Please add support for MX25L8005 and MX25L3205D

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Jan 10 13:56:05 CET 2008

On 10.01.2008 13:39, Harald Gutmann wrote:
> Am Donnerstag, 10. Januar 2008 01:25:44 schrieb Carl-Daniel Hailfinger:
>> Just adding the right values to flashchips.c is not enough. I need
>> "flashrom -V" output both with your patch and without your patch.
> first here is a diff between my "patched" and the actual plain svn version of 
> flashrom:
> diff -ubr flashrom.plain/flashchips.c flashrom.patched/flashchips.c
> --- flashrom.plain/flashchips.c 2008-01-10 13:29:32.000000000 +0100
> +++ flashrom.patched/flashchips.c       2008-01-10 13:32:53.000000000 +0100
> @@ -52,6 +52,8 @@
>          probe_29f002,  erase_29f002,   write_29f002},
>         {"MX25L4005",   MX_ID,          MX_25L4005,     512, 256,
>          probe_spi,     generic_spi_chip_erase_c7,      
> generic_spi_chip_write},
> +       {"MX25L8005",   MX_ID,          MX_25L8005,     1024, 256,
> +        probe_spi,     generic_spi_chip_erase_c7,      
> generic_spi_chip_write},
>         {"SST25VF040B", SST_ID,         SST_25VF040B,   512,    256,
>         probe_spi,      generic_spi_chip_erase_c7,      
> generic_spi_chip_write},
>         {"SST25VF016B", SST_ID,         SST_25VF016B,   2048,   256,

That part of the patch is correct. Can you give me a Signed-off-by:
line? I will ack and commit. See
http://linuxbios.org/Development_Guidelines#Sign-off_Procedure for details.

>>> It would be really fine, if someone of you could implement that
>>> correctly, i can and will test if it works.
>> I can implement support if I have the output mentioned above. Your
>> problem seems to be caused by the flash translation chip and not the
>> flash chip.
> The output of both flashrom versions is attached.

Thanks, I now see that it is indeed a problem with the SPI translation.
Can you try to flash some random data to the rom? Verify will fail. Then
try to read back the rom and upload both original random data and
readback result somewhere (rapidshare etc.) and I'll try to find out
what the flash translation chip really supports.

And please tell me how much RAM the machine has (if it is more than 2
GB, I need the amount of Video RAM as well).


More information about the coreboot mailing list