[coreboot] #92: Add --version option

Bernhard Walle bernhard.walle at gmx.de
Sun Jan 20 22:59:17 CET 2008


Hello,

* Ulf Jordan <jordan at chalmers.se> [2008-01-20 22:48]:
> On Sun, 20 Jan 2008, Bernhard Walle wrote:
>
>> all: pciutils dep $(PROGRAM)
>>
>> +# Set the superiotool version string from the highest revision number
>> +# of the checked out superiotool files.
>
> s/superiotool/flashrom/

Sorry, copy & paste. :)

>> +SVNDEF := -D'FLASHROM_VERSION="$(shell svnversion -cn . \
>> +          | sed -e "s/.*://" -e "s/\([0-9]*\).*/\1/")"'
>> +CFLAGS += $(SVNDEF)
>> +
>> $(PROGRAM): $(OBJS)
>> 	$(CC) -o $(PROGRAM) $(OBJS) $(LDFLAGS)
>> 	$(STRIP) $(STRIP_ARGS) $(PROGRAM)
>> Index: flashrom.c
>> ===================================================================
>> --- flashrom.c	(Revision 3064)
>> +++ flashrom.c	(Arbeitskopie)
>> @@ -206,11 +206,17 @@
>
> Please insert R in the first line of the usage summary too, like for the 
> other options.

Yes, good idea. :)

>> +		case 'R':
>> +			print_version();
>> +			exit(0);
>
> break;

Well, I don't think that that matters after the program was quit. But
for coding style, done.

Thanks for the review!


        Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flashrom-add-version.diff
Type: text/x-patch
Size: 2402 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080120/ac978d43/attachment.diff>


More information about the coreboot mailing list