[coreboot] [PATCH] flashrom: Improve coreboot image detection heuristic

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Jul 3 16:42:39 CEST 2008

On 03.07.2008 16:37, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>> Improve coreboot image detection heuristic in flashrom. It's not
>> absolutely perfect, but the likelihood of this check to fail is
>> 0.000000000000000000000000013 (1.3*10^-26) which is good enough for me. 
> I think at some point we should go to a better concept of doing
> things,  but it seems what you are saying is that your code will
> probably not fail on any bios that has been developed to date, as I
> doubt it is more than 10^26 bioses.

I calculated the likelihood of a false positive detection of coreboot
for a random image. All reports we got about segfaults will be fixed as
well, so I'm reasonably positive this bandaid will last.

> Acked-by: Stefan Reinauer <stepan at coresystems.de>

Thanks, r3408.



More information about the coreboot mailing list