[coreboot] [PATCH] [RFC] v3: CS5536 cleanup, and v3 design

[Peter Stuge]

On Thu, Jul 03, 2008 at 04:47:57PM +0200, Carl-Daniel Hailfinger wrote:
> New iteration.
> 
> - Clean up Geode companion chip CS5536 code.
> - Eliminate a few redundant dev_find_pci_device() calls.
> - Fix a compile warning intruduced in r689.
> 
> This should be an equivalence transformation.
> 
> Build tested on norwich, db800, alix.1c, alix.2c3, dbe62, dbe61.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Peter Stuge <peter at stuge.se>


> @@ -659,7 +649,7 @@
>  
>  	setup_i8259();
>  	lpc_init(sb);
> -	uarts_init(sb);
> +	uarts_init(sb, dev);
>  
>  	if (sb->enable_gpio_int_route) {
>  		printk(BIOS_SPEW, "cs5536: call vr_write\n");

More generally to the v3 design - should we try to create finer
granularity hooks?

I'm thinking per PCI-device in each component rather than per
component?


//Peter