[coreboot] [PATCH] [RFC] v3: CS5536 cleanup, and v3 design

Peter Stuge peter at stuge.se
Thu Jul 3 20:10:06 CEST 2008

On Thu, Jul 03, 2008 at 11:00:49AM -0700, ron minnich wrote:
> > I'm thinking per PCI-device in each component rather than per
> > component?
> We've had this discussion before. It's a tough call: finer granularity
> vs. having lots of fiddly files.

Not neccessarily more files though - primarily more functions.

> That said, your idea is attractive. I am very concerned that we
> maintain readability for non-experts and newbies.

Good, I agree.

> Would this make it more readable in your opinion? If so, it makes
> sense.

Actually yes, I think so, if there is correlation between what is
in the component dts, and what is in the component source.

Maybe some components should be several files, but not neccessarily
as a rule. I've compared with Linux kernel drivers before and will
again. Drivers can be just one .c, but can also be a bunch of them
when that makes sense. This is not top priority of course, right now
I would prefer to keep it at one file per component.


More information about the coreboot mailing list