[coreboot] patch: grow grafix memory, and fix PLL on dbe62
mart.raudsepp at artecdesign.ee
Thu Jul 17 15:03:48 CEST 2008
Ühel kenal päeval, L, 2008-07-12 kell 13:56, kirjutas Uwe Hermann:
> On Fri, Jul 11, 2008 at 08:21:58AM -0700, ron minnich wrote:
> > On Thu, Jul 10, 2008 at 4:32 AM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> > > On Wed, Jul 09, 2008 at 09:05:39AM -0700, ron minnich wrote:
> > >> This grows graphics mem to 16M per artec's recommendation.
> > >
> > > You mean 32MB? The comment says "Video RAM has to be in 2MB chunks", so
> > > either 16M is wrong, or the comment is wrong (?)
> > >
> > > The patch is fine otherwise, but I cannot test...
> > >
> > I will reword that comment. I think the meaning is lost in translation?
> > Video RAM has to be in mulitples of 2 MB
> Ah, yes, makes sense then.
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
> with the updated comment.
What comment would you suggest? Ron never worded it out here.
But to me the existing comment is quite clear. It has to be an even
number of megabytes by my understanding- it goes by 2MB granularity, you
can assign 0, 2, 4, 6, 8, 10, 12, 14, 16 and so on megabytes for video
memory because in the registry meaning it increases in steps of 2MB,
As I did the equivalent changes to DBE61 some months ago when I was
making it boot linux in coreboot-v3, I can commit this soon myself too
with the provided Acks.
So I suggest the following comment:
"Video RAM has to be in a 2MB granularity"
More information about the coreboot