[coreboot] AMD Fam10 HT cleanup
Marc Jones
marc.jones at amd.com
Thu Jul 17 21:55:40 CEST 2008
Carl-Daniel Hailfinger wrote:
> On 17.07.2008 01:39, Jordan Crouse wrote:
>
>> On 17/07/08 01:30 +0200, Carl-Daniel Hailfinger wrote:
>>
>>
>>> On 17.07.2008 00:06, Marc Jones wrote:
>>>
>>>
>>>> Some HT cleanup. Shouldn't be anything major.
>>>>
>>>> Clean up AMD FAM10 HT variable initialization. The structure init is cleaner,
>>>> avoid compiler warnings,
>>>> and matches the AMD example code more closely.
>>>>
>>>> Signed-off-by: Marc Jones <marc.jones at amd.com>
>>>>
>>>>
>>>>
>>> While I do like most parts of the cleanup, I'm not so totally sure about
>>> the structure inits. They are easier to read now, but I wonder whether
>>> C99 initializers would have been the way to go.
>>>
>>>
>> I don't think that Stefan is going to make the repository read-only
>> any time soon. There is no prejudice against future cleanups.
>>
>>
>
> Point taken.
>
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>
> Regards,
> Carl-Daniel
>
>
r3425
More information about the coreboot
mailing list