[coreboot] v3 patch: fix dtc to correctly parse @x values as hex, not decimal.

Peter Stuge peter at stuge.se
Tue Jul 29 21:50:43 CEST 2008

On Tue, Jul 29, 2008 at 09:21:17AM -0700, ron minnich wrote:
> I misunderstood the dts when I wrote this code. 
> The @ values are implicitly hex. Correctly emit hex constants for
> all cases, including the pci a,b syntax. 

Great patch! I just have one general thought..

> -			fprintf(f, "\t.path = {.type=DEVICE_PATH_CPU,.u={.cpu={ .id = %s }}},\n", 
> +			fprintf(f, "\t.path = {.type=DEVICE_PATH_CPU,.u={.cpu={ .id = 0x%s }}},\n", 

Shouldn't dtc actually try to convert these into scalars rather than
storing them as strings, so that errors are caught earlier and better
error messages can be output?

On Tue, Jul 29, 2008 at 07:58:22PM +0200, Stefan Reinauer wrote:
> and possibly a few more files like apic, ide and whatever they're called..
> To make clear what those files are, we should rename them...
> dts -> mainboard.dts
> ide -> ide.dts
> apic -> apic.dts

Yes, I argued strongly for this when they first appeared and even
sent a patch. The problem is that the filenames are tied hard into
the struct names generated by dtc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080729/1415bd94/attachment.sig>

More information about the coreboot mailing list