[coreboot] v3 patch: fix dtc to correctly parse @x values as hex, not decimal.

Stefan Reinauer stepan at coresystems.de
Tue Jul 29 22:05:51 CEST 2008

Peter Stuge wrote:
> On Tue, Jul 29, 2008 at 09:21:17AM -0700, ron minnich wrote:
>> I misunderstood the dts when I wrote this code. 
>> The @ values are implicitly hex. Correctly emit hex constants for
>> all cases, including the pci a,b syntax. 
> Great patch! I just have one general thought..
>> -			fprintf(f, "\t.path = {.type=DEVICE_PATH_CPU,.u={.cpu={ .id = %s }}},\n", 
>> +			fprintf(f, "\t.path = {.type=DEVICE_PATH_CPU,.u={.cpu={ .id = 0x%s }}},\n", 
> Shouldn't dtc actually try to convert these into scalars rather than
> storing them as strings, so that errors are caught earlier and better
> error messages can be output?
> On Tue, Jul 29, 2008 at 07:58:22PM +0200, Stefan Reinauer wrote:
>> and possibly a few more files like apic, ide and whatever they're called..
>> To make clear what those files are, we should rename them...
>> dts -> mainboard.dts
>> ide -> ide.dts
>> apic -> apic.dts
> Yes, I argued strongly for this when they first appeared and even
> sent a patch. The problem is that the filenames are tied hard into
> the struct names generated by dtc.
Hm. I definitely want to support your idea here then.

Adding .dts to the filename is about as hard as not doing that. Also, in 
2 out of 3 dts files I see struct names.

If we'd really autocreate something, we should drop that behavior.

Writing a decent device tree got a lot more complicated than it was in 
v2. And we did not even start adding new features.

v3 ought to be simpler for the user and for the developer of new systems..

we need to focus on that again.

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080729/05dea5ac/attachment.sig>

More information about the coreboot mailing list