[coreboot] [PATCH] [RFC] v3: CS5536 cleanup
rminnich at gmail.com
Wed Jun 4 16:53:36 CEST 2008
So, I went to apply and test this patch, but I guess, on reflection,
I'm pretty uncomfortable with it. Why? Because of this:
This is even worse than putting stuff like this in the code
dev = dev_find_pci_device(PCI_VENDOR_ID_AMD,
pci_write_config32(dev, 0x7C, 0xDEADBEEF);
because at least the latter form doesn't hard code pcidevfn.
I think you are right. hide_vpci should take a dev pointer. So let's
try to rework with that change to hide_vpci and we can then bring this
hide_vpci then becomes pretty simple in fact ...
More information about the coreboot