[coreboot] flashrom: Remove dead M-Systems Disk on Chip code

Stefan Reinauer stepan at coresystems.de
Sun Jun 22 12:24:25 CEST 2008

Peter Stuge wrote:
> Patch attached.
> //Peter
> flashrom: Remove dead M-Systems Disk on Chip code
> DOC support has been disabled by default for many years. The write function
> does nothing but print text. It has a call to write_page_md2802() commented
> out, but that function does not exist. This is dead code with ugly #ifdefs.
> Updates README to reflect that there was a time when there was code, but it
> didn't work. Removes M-Systems #defines and also includes svn rm msys_doc.*
> Signed-off-by: Peter Stuge <peter at stuge.se>

Absolutely NACK.

The reason the code is not compiled in per default is that the probing
takes forever. Still, no reason to drop support.

I don't think we should drop features because we don't like a few ifdefs.

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

More information about the coreboot mailing list