[coreboot] [PATCH] [flashrom] initial numonyx support

Stefan Reinauer stepan at coresystems.de
Fri Jun 27 18:25:35 CEST 2008

* Peter Stuge <peter at stuge.se> [080627 17:48]:
> > * drop erroneous "unknown flash chip" entries. They badly clash with the
> >   "multiple flash chip support" and are no longer required since it's
> >    possible to force a flash chip with Peter's last patch.
> Thumbs up on this. I thought on doing this in my patch, but I wanted
> a flashrom mode that was completely equivalent - ie. it would scan
> for known vendors. But I am fine with removing this right now.
> >  	{"Macronix",	"MX25L3205",		MX_ID,		MX_25L3205,		4096,	256,		TEST_OK_PREW,	probe_spi_rdid,		spi_chip_erase_c7,	spi_chip_write,	spi_chip_read},
> >  	{"Macronix",	"MX29F002",		MX_ID,		MX_29F002,		256,	64 * 1024,	TEST_UNTESTED,	probe_29f002,		erase_29f002,			write_29f002},
> > +       {"Numonyx",     "M25PE80",              ST_ID,          0x8014,                 1024,   256,            TEST_UNTESTED,  probe_spi_rdid,            spi_chip_erase_c7,      spi_chip_write, spi_chip_read},
> Does this indent just break in the patch but look good in your file?

Thanks for noticing. It's indeed broken. I will fix it in the commit if
I get an Acked. 

> And, did you intentionally not make a #define for the product id?

Yes, that is on purpose. I think it is a bad bad idea to define every flash
chip in two different places in two different files in the tree. I think
to remember this was discussed quite a while ago, and to some extent
agreed upon, even.

The array is the only place in the code really using all those defines,
and the each line with the #defined ID also contains the human readable
name of the chip, so it really is a false friend of readability maing
the code uglier and harder to maintain (much like the PCI IDs #define


coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

More information about the coreboot mailing list