[coreboot] [PATCH] [flashrom] initial numonyx support

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 27.06.2008 17:44, Stefan Reinauer wrote:
>   
>> see patch
>>
>> * drop erroneous "unknown flash chip" entries. They badly clash with the
>>   "multiple flash chip support" and are no longer required since it's possible
>>   to force a flash chip with Peter's last patch.
>>   
>>     
>
> NACK that part. The functionality provided by the "unknown xy flash
> chip" entries is still not available otherwise. Removing code just
> because it does not work perfectly as expected is something you opposed
> a few days ago.
>   

And I was convinced that it is ok in case it never worked correctly.


So what do you suggest is the right fix?  Dummy entries is not it.

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866