[coreboot] r3393 - trunk/util/flashrom

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Jun 29 02:16:37 CEST 2008

On 28.06.2008 19:08, Peter Stuge wrote:
> On Sat, Jun 28, 2008 at 06:38:01PM +0200, Peter Stuge wrote:
>> Unfortunately this patch broke flashrom on ICH7 not using SPI for
>> at least one user as reported on IRC just now. :(
> ..
>> I asked the reporter to send a message to flashrom@ and I got a
>> promise about testing patches to fix the problem. :)
> I had an idea. The attached patch fixes flashrom 3393 on non-SPI ICH7
> at least for the reporter.
> The second hunk is needed for me to be able to compile flashrom with
> gcc 4.2.2. That should teach me to build test before I ack. Also
> there seems to be a bit of whitespace damage in the 3393 patch.
> //Peter
> flashrom: Fix ICH7 non-SPI that broke in r3393
> r3393 assumed that ICH7 always used SPI. This patch resets ich7_detected back
> to 0 when BOOT BIOS Straps indicate something else than SPI.
> Also fixes a build error in ichspi.c with gcc 4.2.2.
> Signed-off-by: Peter Stuge <peter at stuge.se>

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

I'd like to know where exactly the hang happens, though. That will allow
us to understand the chipset better.



More information about the coreboot mailing list