[coreboot] [PATCH]ich_gpio_dump util ACK?

joe at smittys.pointclark.net joe at smittys.pointclark.net
Mon Mar 10 18:11:01 CET 2008


Quoting Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>:

> On 10.03.2008 16:30, joe at smittys.pointclark.net wrote:
>> Quoting Peter Stuge <peter at stuge.se>:
>>
>>
>>> On Mon, Mar 10, 2008 at 01:01:24PM +0100, Carl-Daniel Hailfinger wrote:
>>>
>>>> Did we decide on a directory name yet?
>>>>
>>>> intel-debugtools/
>>>> ich_gpio_dump/
>>>>
>>>>
>>>> I'd like to keep all present and future Intel utilities in one
>>>> directory below util/ without deeper structure.
>>>>
>>> ichtools or inteltools then?
>>>
>>>
>>>
>> inteltools sounds good:-)
>>
>
> Could you resend the patch? The last one you sent had this chunk:
>
>> Index: intel-debugtools/ich_gpio_dump/ich_gpio.c
>> ===================================================================
>> --- intel-debugtools/ich_gpio_dump/ich_gpio.c   (revision 0)
>> +++ intel-debugtools/ich_gpio_dump/ich_gpio.c   (revision 0)
>> @@ -0,0 +1,94 @@
>
> However, the file was only 91 lines long. Did you hand-edit the patch
> in some way?
>
yes I hand edited it for Rons requested changes. Here is an un-edited  
rvised patch.

Thanks - Joe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ich_gpio_dump.patch
Type: text/x-patch
Size: 5657 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080310/dced98d4/attachment.patch>


More information about the coreboot mailing list