[coreboot] Makefile simplification for v3

[Myles Watson]

On Thu, Mar 6, 2008 at 5:16 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
>
> On Thu, Mar 06, 2008 at 07:23:45AM -0700, Myles Watson wrote:
>  >
>  >
>  > > -----Original Message-----
>  > > From: Stefan Reinauer [mailto:stepan at coresystems.de]
>  > > Sent: Thursday, March 06, 2008 7:07 AM
>  > > To: Myles Watson
>  > > Cc: Coreboot
>  > > Subject: Re: [coreboot] Makefile simplification for v3
>  > >
>  > > * Myles Watson <mylesgw at gmail.com> [080305 19:27]:
>  > > >   $(Q)# QEMU wants bios.bin:
>  > > >   $(Q)# Run "qemu -L build/ -serial stdio -hda /dev/zero".
>  > > > - $(Q)printf "  CP      $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
>  > > > - $(Q)cp $@ $(obj)/bios.bin
>  > > > + $(Q)# printf "  CP      $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
>  > > > + $(Q)# cp $@ $(obj)/bios.bin
>  > > >   $(Q)echo "Coreboot ROM Image:" > $(obj)/coreboot.map
>  > > >   $(Q)$(obj)/util/lar/lar -l $(obj)/coreboot.rom >>
>  > > $(obj)/coreboot.map
>  > > >   $(Q)(echo; echo "Stage 0/1 Map:") >> $(obj)/coreboot.map
>  > >
>  > > I think this sneaked in... Please make sure you don't commit this.
>  >
>  > You're right.  It should be a separate patch.  I'll make sure I don't commit
>  > it with the rest of this patch.
>  >
>  > I think it would be correct to remove it because it is mainboard specific.
>  > Someone who wants to automate testing could use a symbolic link to
>  > coreboot.rom from their BIOS directory.
>
>  QEMU expects a file called bios.bin, that's why this is done. Now you
>  can just type 'qemu -L build ...' and it works. Not critical, but nice
>  to have, and it doesn't really hurt to leave it in.
>

Yep.

I've attached the original two patches minus the QEMU part.  Which one
do people like better?

Myles

Signed-off-by: Myles Watson <mylesgw at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile_simplify.patch
Type: text/x-patch
Size: 2301 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080311/8b27ff0c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile_simplify.patch2
Type: application/octet-stream
Size: 2343 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080311/8b27ff0c/attachment.obj>