[coreboot] LAR TODO

[Myles Watson]

> >>  >> Myles? Could you prepare a patch which #ifdefs the code instead of
> >>  >> removing it?
> >
> > One part that was strange to me was that I first tried adding elfboot.o
> and
> > archelfboot.o to the beginning of the list of object files.  This broke
> > coreboot.  It still finished building, but would not boot on QEMU.  I
> was
> > surprised that it broke it, but didn't investigate further.
> >
> 
> Did you make distclean in between? v3 dependency handling is something
> between screwed and nonexistent. It does work sometimes, though.
> 

Yes, I did.  It didn't work.

> Sorry, but the chunk above is a real mess. Can't you move the
> conditional chunk to the end and avoid the else path completely?

Yep, this is the ugly place I was talking about.  I had tried to add them to
the beginning of the list, and it wouldn't build.  I tried at the end this
time and it worked.  I still think it's a little strange that the order
mattered.

> 
> The patch would get my Ack except for the Makefile chunk I complained
> about. Please rework that.

See attached.

Thanks,

Myles

Signed-off-by: Myles Watson <mylesgw at gmail.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: opt_no_elf.diff
Type: application/octet-stream
Size: 4049 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080312/f6f0addd/attachment.obj>