[coreboot] [PATCH] Hardcode PCI devices in Intel southbridge early init code

joe at smittys.pointclark.net joe at smittys.pointclark.net
Mon Mar 31 19:16:00 CEST 2008


Quoting Ed Swierk <eswierk at arastra.com>:

> The early init code of several Intel southbridge chipsets calls
> pci_locate_device() to locate the SMBus controller and LPC bridge
> devices on the PCI bus. Since these devices are always located at a
> fixed PCI bus:device:function, the code can be simplified by
> hardcoding the devices.
>
> Signed-off-by: Ed Swierk <eswierk at arastra.com>
>
Looks good, but I don't think we need to add any patches to the  
i82801ca, i82801db, i82801dbm, or i82801er. The southbridge code for  
these should not be used, and should be
dropped. Everyone should be using the i82801xx code for all ICH's. I  
propose we drop that
code now that the i82801xx is stable, so cool people like Ed do not  
waste their time on
it :-)


Thanks - Joe




More information about the coreboot mailing list