[coreboot] [RFC] kill unwanted_vpci, use "hidden" property instead

Ward Vandewege ward at gnu.org
Thu May 8 20:45:39 CEST 2008

On Thu, May 08, 2008 at 12:16:08PM -0600, Marc Jones wrote:
> Carl-Daniel Hailfinger wrote:
> > My current plan is:
> > - encapsulate all those code sequences into calls of one or two functions
> > - switch all calls from hide_vpci(some_value_calculated_by_hand) to
> > hide_vpci_dev(struct device *)
> OK.
> > - replace the central array of hand-calculated values with a
> > per-PCI-device "hidden" property.
> > 
> I think that this will add complications that you don't intend.
> There are two reasons to hide a device.
> 1. Your platform doesn't use the device and so there is no reason for it 
> to hang about. This option was addressed with the array of device 
> location that you noted, but I don't think that anyone used it. (OLPC 
> doesn't count)

Actually, we use it in v3 on the alix.2c3 to disable the VGA device which has
no physical connector present.


Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator

More information about the coreboot mailing list