[coreboot] r3304 - in trunk/util: . inteltool
stepan at coresystems.de
Wed May 14 03:51:49 CEST 2008
Joseph Smith wrote:
> Wow, slow down. I really like all the new stuff Stefan. But is it
> compatable with all the ICH's per datasheets? I see the ICH7 is the only
> tested one. The old gpio_dump was not exactly pretty but it did the job,
> and should have worked on all ICH's per datasheets. Are you sure we should
> have dropped it? If you like in the next day or two I can test it out on
> the ICH4, so it can be added
ICH4 will require very few lines of additional code. But basically the
gpio dump function did not change much. Except now it also prints the
register names. If those changed, older ICHs will need an additional
register description, or they will print the wrong names.
No big magic.
I think we should not implicitly go with "all PCI IDs below this number
follow the old scheme" heuristics, but instead add those ICHs that we
checked explicitly. The infrastructure for doing that is quite in place.
Also, there's a mechanism to disable dumping for example the MCHBAR on
those chipsets that don't have one.
But please, do test this and add the few missing lines to make it work
on your chipset.
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 249 bytes
Desc: OpenPGP digital signature
More information about the coreboot