[coreboot] Add support for SPI-Chips on ICH9 to flash rom / please delete the last mail

Dominik Geyer dominik.geyer at kontron.com
Thu May 15 09:43:23 CEST 2008

Hi Carl-Daniel,

On Wednesday 14 May 2008 17:11, Carl-Daniel Hailfinger wrote:
> On 14.05.2008 16:17, Carl-Daniel Hailfinger wrote:
> > Hi Claus,
> > hi Dominik,
> >
> > On 14.05.2008 08:23, Claus Gindhart wrote:
> >> Hi Carl-Daniel,
> >>
> >> my colleague Dominik will investigate into this; we will provide a new
> >> patch within the next few days.
> >
> > Thanks. By the way, the ICH8 datasheet says your code will not work with
> > ICH8 (wrong SPIBAR address), so you might want to remove ICH8 bits from
> > the patch. Hardcoding the RCRB address is a problem as well.
> >
> > I have sent another patch a few minutes ago which will allow you to
> > replace is_supported_chipset() with ich9_detected and
> > curflash->virtual_registers with *ich_spibar. That patch also calculates
> > the correct RCRB address and the correct SPIBAR address. The subject of
> > the mail was "[coreboot] [PATCH] flashrom: Infrastructure for ICH9
> > merge".
> That patch has been merged in r3314. You can also drop
> munmap_ich_registers() and map_ich_registers() now.
> If you can create a wrapper for run_opcode() which can be called from
> spi_command(), you should be able to drop ~80% of the code in ichspi.c.
> Such a wrapper would look up the opcode from spi_command() in the list
> of programmed opcodes and convert the arguments. AFAICS this should be
> easy.

Sounds good. Your infrastructure/restructure patches are a nice approach. I 
will adjust our code and provide you with the patches.


Dominik Geyer
- SW R&D -

Kontron Modular Computers
Sudetenstraße 7
D - 87600 Kaufbeuren
Tel.: +49 (0) 83 41 / 803 -395

dominik.geyer at kontron.com

Kontron Modular Computers GmbH
Geschaeftsfuehrer / Managing Directors: Ulrich Gehrmann, Thomas Sabisch 
Sitz der Gesellschaft / Registered Office: Kaufbeuren, Rechtsform / Legal: GmbH 
Amtsgericht / Local District Court Kempten, HRB Nr. / Trade Register No. 6195
The information contained in this document is CONFIDENTIAL and property of Kontron.
Any unauthorized review, use, disclosure or distribution is prohibited without express
written consent of Kontron. If you are not the intended recipient, please contact the
sender and destroy all copies of the original message and enclosed attachments.

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen und ist
Eigentum von Kontron. Die Verwendung und Weitergabe von jeglichen Inhalten ist
ohne ausdrückliche schriftliche Genehmigung von Kontron strikt untersagt. Wenn Sie
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten diese Mail und enthaltene Dokumente.

More information about the coreboot mailing list