[coreboot] [PATCH] flashrom: Add support for SPI-Chips on ICH9

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri May 16 15:45:55 CEST 2008

Hi Dominik,

On 16.05.2008 15:02, Carl-Daniel Hailfinger wrote:
> On 16.05.2008 11:45, Dominik Geyer wrote:
>> Add support for SPI-Chips on ICH9. This is done by using the generic SPI 
>> interface.
> This is really Great Stuff (TM)
> Thanks! I have looked at the structure and implementation details of
> your code and it is definitely ready for merging. There are a few things
> (mostly cosmetic, like outdated comments) I'd like to be fixed, but they
> are not showstoppers.

There's another question I have for you: How should we handle the
situation if the opcode table has been locked by the BIOS? One way would
be to load the locked opcode table from the southbridge and proceed as
normal. If any opcodes we want are not in the table, fail the
transaction with an error message. program_opcodes() could check the
lock bit and return failure, then another function would malloc
curopcodes and read the chipset opcodes into it.

By the way, some people have volunteered to test flashrom on ICH7 and I
think ICH7/ICH8 support would be rather easy to add to the ICH9 driver,
resulting in improved testing coverage. It's your decision, though, and
I am very thankful you wrote the ICH9 driver.


More information about the coreboot mailing list