[coreboot] [PATCH] flashrom: Add support for 8 new chips, fix up 2 existing chips
uwe at hermann-uwe.de
Tue Nov 4 12:58:04 CET 2008
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
On Mon, Nov 03, 2008 at 02:24:13AM +0100, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
> > +#define MX_29F002B 0x34
> > +#define MX_29F002T 0xB0
> Yeah. Please don't do this. Put them in the struct.
I don't remember the outcome of that flashrom discussion a while ago,
but either way, this shouldn't hold up the commit. If we want to get rid
of the #defines that should happen in one commit for all of the chips.
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot