[coreboot] [PATCH] artecgroup/dbe61: Set up NAND and USB power handling settings

[Mart Raudsepp]

Ühel kenal päeval, K, 2008-11-12 kell 19:15, kirjutas Carl-Daniel
Hailfinger:
> On 12.11.2008 19:06, Mart Raudsepp wrote:
> > artecgroup/dbe61: Set up NAND and USB power handling settings
> >
> > Also upper-cases the hex in lpc_serirq_polarity as all other Geode boards have it as such,
> > and remove parts of the commented out reference v2 setup block that should be handled by
> > this change now.
> >
> > Oddly enough the USB power handling setting (that was to get the other pair of USB
> > ports powered during DBE62 work) actually make memtest work, while without it it gets
> > unexpected interrupt halts. The SPD commit earlier missed this local change as an unrelated
> > one.
> >   
> 
> The paragraph above is a bit unclear to me. What's the relationship
> between memtest and the other pair of USB ports? Do they both work now
> or is it an "either or" decision?

No, it's that without the pph = "0xf5"; memtest payload fails to test
memory and instead halts with an unexpected interrupt error. On Friday
when sending and committing the patch for getting the fake SPD suitable
for DBE61C I had this USB power setting as an additional change in my
local tree, so technically the commit on Friday didn't make memtest work
fine yet as claimed in commit message, but did get the timings usable.
So it's odd that that pph dts setting for USB power handling affects
memtest working or not.

> 
> > Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
> >   
> 
> With an improved working of the commit message, this is
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> Regards,
> Carl-Daniel
>