[coreboot] [PATCH 5/5] Be less noisy in ram_check in non-debug loglevels

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Nov 13 02:32:46 CET 2008


On 13.11.2008 02:07, Peter Stuge wrote:
> Mart Raudsepp wrote:
>   
>> Be less noisy in ram_check in non-debug loglevels
>>
>> As DBE61 support now runs ram_check for non-debug purposes and has expected failures,
>> downgrade the per-address looped fail notification printk from BIOS_ERR to BIOS_DEBUG.
>> To compensate promote the one-time result print from DEBUG to ERR if it was a failure.
>>
>> Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
>>     
>
> Acked-by: Peter Stuge <peter at stuge.se>
>   

I'm not so totally sure we really want this change. I won't veto it, but
I think RAM test errors should always be shown with full verbosity. If
it is really needed, you could add another parameter to ram_check which
specifies the log level.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list