[coreboot] [PATCH 3/5] artecgroup/dbe61: Gather RAM initialization function calls to one helper function.
peter at stuge.se
Thu Nov 13 05:14:30 CET 2008
Carl-Daniel Hailfinger wrote:
> The GeodeLX RAM init code also suffers from ROMCC mentality.
Yes, this is why I think v3 is not in such a good shape. I also think
that by shaping it up we could pull out several things that can be
reused all over the place.
> A prime example is the check whether a SPD is in a given slot.
> Moving that check outside the functions would probably kill a dozen
> lines of code, if not more.
I'd love to review and ack the patch if you feel like improving that!
More information about the coreboot