[coreboot] [PATCH] v3: Add/use global PNP enter/exit functions forSuper I/Os
corey.osgood at gmail.com
Tue Nov 18 21:50:12 CET 2008
On Tue, Nov 18, 2008 at 3:34 PM, Myles Watson <mylesgw at gmail.com> wrote:
> > This is the start of a v3 superio refactoring, more will follow.
> > Build-tested on one or two targets.
> for fintek:
> -static void pnp_enter_conf_state(struct device *dev)
> - outb(0x87, dev->path.pnp.port);
> - pnp_enter_conf_state(dev);
> + pnp_enter_8787(dev);
> I don't know that much about SuperIOs, but does it matter that you replaced
> one outb with two?
No, it doesn't, I've used two 0x87s on actual hardware.
> At least in pnp_enter_ite() it seems to matter.
> Besides that it looks good.
> Acked-by: Myles Watson <mylesgw at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot