[coreboot] r1047 - coreboot-v3/lib

[svn at coreboot.org]

Author: mraudsepp
Date: 2008-11-20 13:20:35 +0100 (Thu, 20 Nov 2008)
New Revision: 1047

Modified:
   coreboot-v3/lib/ramtest.c
Log:
Be silent in ram_check in non-debug loglevels

As DBE61 support now runs ram_check for non-debug purposes and has expected failures
on DBE61A, downgrade the per-address looped fail notification printk and other messages
from BIOS_ERR to BIOS_DEBUG.
Document that if something is wanted to be reported in non-debug loglevels, one should
do so in the caller based on the return value.
Tweak a debug string in ram_verify to be more descriptive.

Signed-off-by: Mart Raudsepp <mart.raudsepp at artecdesign.ee>
Acked-by: Peter Stuge <peter at stuge.se>

Modified: coreboot-v3/lib/ramtest.c
===================================================================
--- coreboot-v3/lib/ramtest.c	2008-11-19 03:11:52 UTC (rev 1046)
+++ coreboot-v3/lib/ramtest.c	2008-11-20 12:20:35 UTC (rev 1047)
@@ -97,11 +97,11 @@
 		value = ram_read_phys(addr);
 		if (value != addr) {
 			/* Display address with error. */
-			printk(BIOS_ERR, "Fail @%lx Read value=%lx\n",
+			printk(BIOS_DEBUG, "Fail @%lx Read value=%lx\n",
 			       addr, value);
 			/* Abort after 256 verify errors. */
 			if (++i > 256) {
-				printk(BIOS_ERR, "Aborting.\n");
+				printk(BIOS_DEBUG, "256 errors seen, aborting.\n");
 				break;
 			}
 		}
@@ -111,7 +111,7 @@
 	printk(BIOS_DEBUG, "%lx\r", addr);
 
 	/* Print whether or not the verify failed. */
-	printk(BIOS_DEBUG, "\nDRAM range %sverified.", i ? "_NOT_ " : "");
+	printk(BIOS_DEBUG, "\nDRAM range %sverified.\n", i ? "_NOT_ " : "");
 	return i;
 }
 
@@ -121,6 +121,8 @@
  *
  * This is much more of a "Is my DRAM properly configured?" test than
  * a "Is my DRAM faulty?" test, though.
+ * If you want to show a message of the result in non-debug loglevels, be sure
+ * to do so yourself based on the return value.
  *
  * @param start The beginning of the RAM area.
  * @param stop The end of the RAM area.