[coreboot] r1057 - in coreboot-v3/arch/x86: . intel/core2
c-d.hailfinger.devel.2006 at gmx.net
Wed Nov 26 03:21:45 CET 2008
On 26.11.2008 02:43, Stefan Reinauer wrote:
> svn at coreboot.org wrote:
>> Author: hailfinger
>> Date: 2008-11-26 00:39:31 +0100 (Wed, 26 Nov 2008)
>> New Revision: 1057
>> The Core2Duo CAR code did set up the stack incorrectly. In combination
>> with a wrong calling convention of stage1_phase1() this caused stage1 to
>> assume BIST had failed.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>> Acked-by: Ronald G. Minnich <rminnich at gmail.com>
> Can you please back this out again? With this code nothing seems to work
I kept the added comments and the two initial pushl $0. Committed in r1058.
If it still fails with svn HEAD, feel free to revert the additional
pushl $0. If the code does fail after that, the breakage was introduced
before my commit (or gcc/gas are malfunctioning).
More information about the coreboot